MongoDB to MongoDb #7034
MongoDB to MongoDb #7034
Conversation
| @@ -34,7 +34,7 @@ class AdapterPluginManager extends AbstractPluginManager | |||
| 'memcache' => 'Zend\Cache\Storage\Adapter\Memcache', | |||
| 'memcached' => 'Zend\Cache\Storage\Adapter\Memcached', | |||
| 'memory' => 'Zend\Cache\Storage\Adapter\Memory', | |||
| 'mongodb' => 'Zend\Cache\Storage\Adapter\MongoDB', | |||
| 'mongodb' => 'Zend\Cache\Storage\Adapter\MongoDd', | |||
|
We can't change the casing of classes existing before 2.4, @marc-mabe |
|
@Ocramius The PR is for |
|
@Ocramius You forgot the label |
| */ | ||
| class MongoDB extends AbstractWriter | ||
| class MongoDb extends AbstractWriter |
There was a problem hiding this comment.
Cannot change this, as it was already released in 2.3
|
Log and Session changes need to be reverted |
|
@Ocramius Now I know what you mean. I'll remove the commit for Log and Session and move it into another PR marked for ZF3 |
|
@marc-mabe thanks for understanding the trouble with this kind of rename :-) |
Ocramius
added
awaiting author updates
and removed
awaiting author updates
BC Break
labels
|
@Ocramius you are welcome :-) |
|
@marc-mabe merged, thanks! |
|
@Ocramius and @marc-mabe : this is a BC break, plain and simple. While many (most?) people will be using the SM in order to setup the log, cache, and session adapters, the problem is that anybody who was manually instantiating the classes previously now has broken code, as the classes will no longer resolve — and, frankly, for no good or apparent reason. CS should have been considered before releasing these as stable; once we go stable, we have to live with the names until the next major revision. I'm thinking we should revert this, and we can re-apply for 3.0. I'm flagging this to revert. |
See #7034 This reverts commit e97c3dd, reversing changes made to 7440246. The changes made in the original merge are backwards incompatible, and should wait until v3 or Zend\Cache. Renaming at this time would break code for existing users, particularly those who were referencing the classes by name.
|
I've reverted this in the current develop branch. @marc-mabe Please re-submit after we break the cache component into its own repo, and we can start considering v3 patches. |
|
@weierophinney why did you revert? This stuff was not yet in a stable tag. |
|
DAMMIT! I missed that aspect. Reverting the revert... |
…ngoDB_to_MongoDb MongoDB to MongoDb
…-mabe/MongoDB_to_MongoDb" See zendframework/zendframework#7034 This reverts commit e97c3ddcb4263ca111fe8c53ce00b935634c690a, reversing changes made to 7440246ae32bd3dab5cff7dac5afe17f16dc8bc8. The changes made in the original merge are backwards incompatible, and should wait until v3 or Zend\Cache. Renaming at this time would break code for existing users, particularly those who were referencing the classes by name.
…rom marc-mabe/MongoDB_to_MongoDb"" See zendframework/zendframework#7034 This reverts commit a1dc4b0883e97a01d89472a5d3eca8e8c55a1e3a. The renames that happened were in unreleased code. As such, they were 100% safe. This commit reverts the revert, restoring the original merge.
Our coding style defines names to be in CamelCase but this one was MIXEDCase.
The cache adapter wasn't released until now so this is no BC break but the session save handler and the log writer i thing. But normally PHP classes and methods are case-insensitive so this can only be an issue with some autoloaders on case-sensitive fs.
I think it's OK for the next minor release.
@Ocramius thoughts ?