added basic support for digest authentication on curl adapters

[yp28]

Missed it, added basic support for HTTP Digest authentication on cURL requests.

[weierophinney]

Please supply unit tests, if at all possible. (You have until 19 March 2015 to do so if you want to see this included in 2.4).

The unit test could test that prepareHeader() prepares the DIGEST authentication headers (you can use reflection to make the method accessible so you can invoke it from the test).

[yp28]

Thanks for your feedback. I have to say, this is my first time contributing to an open source project, and I'm not familiar with pull requests either.

I'd like to contribute, so any feedback on how and what I should do or how I can improve is much appreciated. Everyone has to start somewhere, right? ;-)

[weierophinney]

@yp28 test looks great!

Only issue I have is coding standards; I'll take care of them on merge, however. In the future, you can take care of them yourself quite easily.

• Run composer install from the project root.
• Then run vendor/bin/php-cs-fixer fix {filename} --config-file=.php_cs on each file you've changed.
• Review the changes introduced, and commit them.

[weierophinney]

Merged to develop for release with 2.4.

[yp28]

Awesome, thanks for the feedback! Added this page as a bookmark for personal future reference.