Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

fix name conflicts between array.slice and string.slice #191

Merged
merged 3 commits into from
Dec 28, 2017
Merged

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Dec 28, 2017

Issue : fix #190

Conflicted names are now aliased when using top level imports.

Examples

Classic operations

import { arrayConcat, stringConcat } from 'immutadot'
// or
const { arrayConcat, stringConcat } = require('immutadot')

chain operations

import { chain } from 'immutadot'
import 'immutadot/seq/all'

chain(obj)
  .arrayConcat('a.b.c', [3, 4])
  .stringConcat('d.e.f', 'foo')
  .value()

Flow operations

import { flow, arrayConcat, stringConcat } from 'immutadot/flow'

@nlepage nlepage added this to the 1.0.0-rc.4 milestone Dec 28, 2017
@nlepage nlepage self-assigned this Dec 28, 2017
@codecov-io
Copy link

codecov-io commented Dec 28, 2017

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #191   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          98     98           
  Lines         353    353           
=====================================
  Hits          353    353
Impacted Files Coverage Δ
packages/immutadot/src/string/concat.js 100% <ø> (ø) ⬆️
packages/immutadot/src/string/slice.js 100% <ø> (ø) ⬆️
packages/immutadot/src/array/concat.js 100% <ø> (ø) ⬆️
packages/immutadot/src/array/slice.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308ef9e...3476124. Read the comment docs.

@frinyvonnick
Copy link
Contributor

Can we document it somewhere ?

@nlepage
Copy link
Member Author

nlepage commented Dec 28, 2017

Maybe on the JSDoc of the affected functions ?

@nlepage nlepage merged commit f4dabbd into master Dec 28, 2017
@nlepage nlepage deleted the fix/190 branch December 28, 2017 10:54
frinyvonnick pushed a commit that referenced this pull request Jan 3, 2018
* 🐛 fix name conflicts between array.slice and string.slice

* ♻️ Consistent aliased names on seq.chain

* 💡 Mention aliased names in JSDoc
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name conflict between array.concat and string.concat
3 participants