Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Benchmark immutadot and display results on front page #196

Merged
merged 13 commits into from
Jan 3, 2018
Merged

Conversation

frinyvonnick
Copy link
Contributor

Prerequisites

Description

Benchmark immutadot with immer's benchmark and display results in README

Issue : #194

Sorry, something went wrong.

@frinyvonnick frinyvonnick requested a review from nlepage as a code owner January 3, 2018 15:46
@frinyvonnick frinyvonnick changed the base branch from master to enhance/doc January 3, 2018 15:46
@codecov-io
Copy link

codecov-io commented Jan 3, 2018

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #196   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          98     98           
  Lines         353    353           
=====================================
  Hits          353    353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd43609...69cbadd. Read the comment docs.

@frinyvonnick frinyvonnick changed the base branch from enhance/doc to master January 3, 2018 16:06
README.md Outdated
@@ -190,6 +190,18 @@ toLowerCase({ nested: { prop: { 1: { msg: 'Hello' }, 2: { msg: 'Hi' }, 3: { msg

When applying operations on a path immutad●t tries to create the minimum of objects or arrays needed to guarantee your data structure to be immutable.

[mweststrate](https://github.com/mweststrate) made a [simple benchmark](https://github.com/Zenika/immutadot/tree/master/packages/immutadot-benchmark/src/performance.spec.js) on the performance of [immer](https://github.com/mweststrate/immer) and other methods for setting a property on multiple items of a todo list and keep it immutable. Here are the results with immutad●t in addition:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention here some information on hardware (MacBook Pro...) and software (node 8, without parallelism)...

@@ -190,6 +190,18 @@ toLowerCase({ nested: { prop: { 1: { msg: 'Hello' }, 2: { msg: 'Hi' }, 3: { msg

When applying operations on a path immutad●t tries to create the minimum of objects or arrays needed to guarantee your data structure to be immutable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put that under benchmark, this is a memory related information, memory is less relevant than speed to JS developers...

@nlepage
Copy link
Member

nlepage commented Jan 3, 2018

Should we merge like this or add more benchmarks ?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nlepage nlepage added this to the 1.0 documentation milestone Jan 3, 2018
@frinyvonnick
Copy link
Contributor Author

I think we can add more benchmarks later maybe about number of instantiate objects ?

frinyvonnick and others added 3 commits January 3, 2018 23:52

Verified

This commit was signed with the committer’s verified signature.
nlepage Nicolas Lepage

Verified

This commit was signed with the committer’s verified signature.
nlepage Nicolas Lepage
@nlepage
Copy link
Member

nlepage commented Jan 3, 2018

Fine with me 👍

@nlepage nlepage merged commit c6bea27 into master Jan 3, 2018
@nlepage nlepage deleted the doc/benchmark branch January 3, 2018 23:01
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants