-
Notifications
You must be signed in to change notification settings - Fork 4
Benchmark immutadot and display results on front page #196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 98 98
Lines 353 353
=====================================
Hits 353 353 Continue to review full report at Codecov.
|
9c85cb8
to
5f64819
Compare
9f9ea84
to
38cae23
Compare
README.md
Outdated
@@ -190,6 +190,18 @@ toLowerCase({ nested: { prop: { 1: { msg: 'Hello' }, 2: { msg: 'Hi' }, 3: { msg | |||
|
|||
When applying operations on a path immutad●t tries to create the minimum of objects or arrays needed to guarantee your data structure to be immutable. | |||
|
|||
[mweststrate](https://github.com/mweststrate) made a [simple benchmark](https://github.com/Zenika/immutadot/tree/master/packages/immutadot-benchmark/src/performance.spec.js) on the performance of [immer](https://github.com/mweststrate/immer) and other methods for setting a property on multiple items of a todo list and keep it immutable. Here are the results with immutad●t in addition: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mention here some information on hardware (MacBook Pro...) and software (node 8, without parallelism)...
@@ -190,6 +190,18 @@ toLowerCase({ nested: { prop: { 1: { msg: 'Hello' }, 2: { msg: 'Hi' }, 3: { msg | |||
|
|||
When applying operations on a path immutad●t tries to create the minimum of objects or arrays needed to guarantee your data structure to be immutable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put that under benchmark, this is a memory related information, memory is less relevant than speed to JS developers...
Should we merge like this or add more benchmarks ? |
I think we can add more benchmarks later maybe about number of instantiate objects ? |
Fine with me 👍 |
Prerequisites
Description
Benchmark immutadot with immer's benchmark and display results in README
Issue : #194