Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unable to rebuild with Electron 28 and zmq ^5 - Error: node-gyp failed to rebuild #591

Open
dawadam opened this issue Dec 13, 2023 · 3 comments
Labels

Comments

@dawadam
Copy link

dawadam commented Dec 13, 2023

Describe the bug
It's a bug that seems to be known; I saw that builds have been made for other versions of Electron. This is version 28. I need it with version 5.3.1 of zeromq. The build is not done correctly with node-gyp.
Error: make failed with exit code: 2

Reproducing
Just install last Eletron, using electronforge and add zmq 5.

Expected behavior
zmq must rebuild

Tested on

  • OS: Linux Mint 21.2
  • ZeroMQ.js version: 5.3.1
@dawadam dawadam added the bug label Dec 13, 2023
@dmikushin
Copy link

You did not provide any details of your error. But I think I get the same node-gyp error:

~/.cache/node-gyp/21.4.0/include/node/v8-local-handle.h:253:42: error: static assertion failed: type check
  253 |     static_assert(std::is_base_of<T, S>::value, "type check");
      |                                          ^~~~~
~/.cache/node-gyp/21.4.0/include/node/v8-local-handle.h:253:42: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
make: *** [zmq.target.mk:113: Release/obj.target/zmq/binding.o] Error 1
make: Leaving directory '~/majordomo/node_modules/zeromq/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2

@dmikushin
Copy link

The error above is for v5.3.1, and it goes away with the latest version, that is if I specify "zeromq": ">= 6.0.0-beta.19" in "dependencies".

@dawadam
Copy link
Author

dawadam commented Jan 1, 2024

Version 6 is a beta version, it's good for me.
But I use another library which uses the production version which is version 5.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants