Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

some x86_64 self-hosted backend std lib tests are disabled #15329

Open
Tracked by #17748
andrewrk opened this issue Apr 16, 2023 · 0 comments
Open
Tracked by #17748

some x86_64 self-hosted backend std lib tests are disabled #15329

andrewrk opened this issue Apr 16, 2023 · 0 comments
Labels
arch-x86_64 64-bit x86 backend-self-hosted bug Observed behavior contradicts documented or intended behavior enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library.
Milestone

Comments

@andrewrk
Copy link
Member

andrewrk commented Apr 16, 2023

The CI has test coverage for x86 backend standard library tests, however some of them are disabled:

$ grep -RI 'stage2_x86_64.*Skip' lib/std/
lib/std/simd.zig:    if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
lib/std/simd.zig:    if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
lib/std/simd.zig:    if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
lib/std/simd.zig:    if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
lib/std/crypto/utils.zig:    if (@import("builtin").zig_backend == .stage2_x86_64) return error.SkipZigTest;
lib/std/math/big/int_test.zig:    if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
lib/std/math/big/int_test.zig:    if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
lib/std/hash/xxhash.zig:    if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
lib/std/hash/xxhash.zig:    if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
lib/std/hash/xxhash.zig:    if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;

Once the above list becomes small enough, this issue can be split into several follow-up issues.

This is a prerequisite to making the x86_64 self-hosted backend the default backend for debug builds.

Related:

@andrewrk andrewrk added bug Observed behavior contradicts documented or intended behavior enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library. arch-x86_64 64-bit x86 backend-self-hosted labels Apr 16, 2023
@andrewrk andrewrk added this to the 0.12.0 milestone Apr 16, 2023
@andrewrk andrewrk modified the milestones: 0.14.0, 0.13.0 Oct 23, 2023
@andrewrk andrewrk changed the title x86_64 self-hosted backend std lib tests are failing some x86_64 self-hosted backend std lib tests are disabled Oct 23, 2023
@mlugg mlugg moved this to Ditch LLVM in Performance Aug 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
arch-x86_64 64-bit x86 backend-self-hosted bug Observed behavior contradicts documented or intended behavior enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library.
Projects
Status: Ditch LLVM
Development

No branches or pull requests

1 participant