From fc9db4734457413bff10896cc00c48a372783e74 Mon Sep 17 00:00:00 2001 From: "Christopher X. Candreva" Date: Thu, 5 Jan 2017 12:01:51 -0500 Subject: [PATCH 1/7] Add NetBeans dir to .gitignore --- .gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 2cf7a3f..fe20083 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,2 @@ -composer.lock \ No newline at end of file +composer.lock +/nbproject From 15b3c385f51ce44fa46e4619335a5b00ead1505b Mon Sep 17 00:00:00 2001 From: "Christopher X. Candreva" Date: Thu, 5 Jan 2017 12:02:06 -0500 Subject: [PATCH 2/7] Add console command example. --- Command/HelloCommand.php | 40 +++++++++++++++++++++++++++++++++++ Resources/config/services.xml | 5 +++++ 2 files changed, 45 insertions(+) create mode 100644 Command/HelloCommand.php diff --git a/Command/HelloCommand.php b/Command/HelloCommand.php new file mode 100644 index 0000000..5b21679 --- /dev/null +++ b/Command/HelloCommand.php @@ -0,0 +1,40 @@ +translator = $container->get('translator.default'); + } + + protected function configure() + { + $this + ->setName('specmodule:hello') + ->setDescription('Print hello message.') + ->setHelp('This command is just a test.'); + } + + protected function execute(InputInterface $input, OutputInterface $output) + { + $io = new SymfonyStyle($input, $output); + $io->text($this->translator->__('Hello, world.')); + } + +} \ No newline at end of file diff --git a/Resources/config/services.xml b/Resources/config/services.xml index 8efdde6..1b43780 100644 --- a/Resources/config/services.xml +++ b/Resources/config/services.xml @@ -15,5 +15,10 @@ %kernel.environment% + + + + + \ No newline at end of file From cb0d2b6d5536fcb4149018627fdb8d3c02a877ce Mon Sep 17 00:00:00 2001 From: "Christopher X. Candreva" Date: Thu, 5 Jan 2017 12:06:42 -0500 Subject: [PATCH 3/7] Fix CI style errors. --- Command/HelloCommand.php | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Command/HelloCommand.php b/Command/HelloCommand.php index 5b21679..cb08bba 100644 --- a/Command/HelloCommand.php +++ b/Command/HelloCommand.php @@ -4,7 +4,6 @@ use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand; use Symfony\Component\DependencyInjection\ContainerInterface; -use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Input\InputInterface; use Symfony\Component\Console\Output\OutputInterface; use Symfony\Component\Console\Style\SymfonyStyle; @@ -16,13 +15,13 @@ class HelloCommand extends ContainerAwareCommand * @var TranslatorInterface */ protected $translator; - + public function setContainer(ContainerInterface $container = null) { parent::setContainer($container); $this->translator = $container->get('translator.default'); - } - + } + protected function configure() { $this @@ -30,11 +29,11 @@ protected function configure() ->setDescription('Print hello message.') ->setHelp('This command is just a test.'); } - + protected function execute(InputInterface $input, OutputInterface $output) { $io = new SymfonyStyle($input, $output); $io->text($this->translator->__('Hello, world.')); } - + } \ No newline at end of file From a52720b1635a32b9dc3cf3fb7c2f20a61278092f Mon Sep 17 00:00:00 2001 From: "Christopher X. Candreva" Date: Thu, 5 Jan 2017 12:08:19 -0500 Subject: [PATCH 4/7] Fix CI style errors. --- Command/HelloCommand.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Command/HelloCommand.php b/Command/HelloCommand.php index cb08bba..018410e 100644 --- a/Command/HelloCommand.php +++ b/Command/HelloCommand.php @@ -35,5 +35,4 @@ protected function execute(InputInterface $input, OutputInterface $output) $io = new SymfonyStyle($input, $output); $io->text($this->translator->__('Hello, world.')); } - -} \ No newline at end of file +} From 53023db5f1485558840de89647071d2c757d211f Mon Sep 17 00:00:00 2001 From: "Christopher X. Candreva" Date: Thu, 5 Jan 2017 12:09:03 -0500 Subject: [PATCH 5/7] Fix CI style errors. --- Command/HelloCommand.php | 1 - 1 file changed, 1 deletion(-) diff --git a/Command/HelloCommand.php b/Command/HelloCommand.php index 018410e..5105341 100644 --- a/Command/HelloCommand.php +++ b/Command/HelloCommand.php @@ -8,7 +8,6 @@ use Symfony\Component\Console\Output\OutputInterface; use Symfony\Component\Console\Style\SymfonyStyle; - class HelloCommand extends ContainerAwareCommand { /** From 1c2496de78a79732371b27184e52f10c24fe50f9 Mon Sep 17 00:00:00 2001 From: "Christopher X. Candreva" Date: Thu, 5 Jan 2017 15:15:56 -0500 Subject: [PATCH 6/7] Remove config from services.xml, add hasCommands to bundle def class. --- Resources/config/services.xml | 5 ----- ZikulaSpecModule.php | 12 +++++++++++- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/Resources/config/services.xml b/Resources/config/services.xml index 1b43780..8efdde6 100644 --- a/Resources/config/services.xml +++ b/Resources/config/services.xml @@ -15,10 +15,5 @@ %kernel.environment% - - - - - \ No newline at end of file diff --git a/ZikulaSpecModule.php b/ZikulaSpecModule.php index d960bf6..317c7c9 100644 --- a/ZikulaSpecModule.php +++ b/ZikulaSpecModule.php @@ -14,5 +14,15 @@ use Zikula\Core\AbstractModule; class ZikulaSpecModule extends AbstractModule -{ +{ + /** + * This function is necesssary for console commands in Command/*Command.php + * to be recognized by app/console.php + * + * @return boolean + */ + protected function hasCommands() + { + return true; + } } From 46bad3e42b4f1117189d3ebaef6bbc4a90f13b88 Mon Sep 17 00:00:00 2001 From: "Christopher X. Candreva" Date: Thu, 5 Jan 2017 15:18:02 -0500 Subject: [PATCH 7/7] Update to pass CI checks. --- ZikulaSpecModule.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ZikulaSpecModule.php b/ZikulaSpecModule.php index 317c7c9..ff3657b 100644 --- a/ZikulaSpecModule.php +++ b/ZikulaSpecModule.php @@ -14,15 +14,15 @@ use Zikula\Core\AbstractModule; class ZikulaSpecModule extends AbstractModule -{ - /** +{ + /** * This function is necesssary for console commands in Command/*Command.php * to be recognized by app/console.php - * + * * @return boolean */ protected function hasCommands() { - return true; + return true; } }