fix(cache): don't use super.read in denormalizedRead so OptimisticCac…

…he overrides it's behavior
zino-hofmann · May 29, 2019 · 38d3588 · 38d3588
1 parent c4fba99
commit 38d3588
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/packages/graphql/lib/src/cache/normalized_in_memory.dart b/packages/graphql/lib/src/cache/normalized_in_memory.dart
@@ -65,7 +65,7 @@ class NormalizedInMemoryCache extends InMemoryCache {
   /// *WARNING* if your system allows cyclical references, this will break
   dynamic denormalizedRead(String key) {
     try {
-      return Traversal(_denormalizingDereference).traverse(super.read(key));
+      return Traversal(_denormalizingDereference).traverse(read(key));
     } catch (error) {
       if (error is StackOverflowError) {
         throw NormalizationException(

diff --git a/packages/graphql/lib/src/core/observable_query.dart b/packages/graphql/lib/src/core/observable_query.dart
@@ -17,7 +17,6 @@ enum QueryLifecycle {
   SIDE_EFFECTS_PENDING,
   SIDE_EFFECTS_BLOCKING,
 
-  // right now only Mutations ever become completed
   COMPLETED,
   CLOSED
 }