feat: Updated all modules to new Zscaler RHEL9 Images #18
Conversation
willguibr
added
documentation
| @@ -39,7 +39,7 @@ resource "aws_key_pair" "deployer" { | |||
|
|
|||
| resource "local_file" "private_key" { | |||
| content = tls_private_key.key.private_key_pem | |||
| filename = "../${var.name_prefix}-key-${random_string.suffix.result}.pem" | |||
| filename = "./${var.name_prefix}-key-${random_string.suffix.result}.pem" | |||
There was a problem hiding this comment.
@willguibr no concerns here. just curious what was the driver to bump this file right up to the specific examples dir rather than /examples itself?
There was a problem hiding this comment.
@jmolnar-zscaler When you deploy, the VM, then to authenticate to it after, you have to go out of the i.e base_ac folder in order to use the key. I found it easier to store all generated artifacts directly in the folder you're already executing the module from. Was there a design issue with that?
examples/ac_asg/main.tf
Outdated
| @@ -256,7 +287,7 @@ module "ac_asg" { | |||
| depends_on = [ | |||
| module.zpa_provisioning_key, | |||
| local_file.user_data_file, | |||
There was a problem hiding this comment.
@willguibr this file is actually not needed and we ran into a weird terraform/aws dependency problem with customers that weren't storing this file after the initial run in their CICD. you can just remove both of those lines of local_file in depends_on for all examples reference
## [1.5.0](v1.4.0...v1.5.0) (2024-07-25) ### Features * Updated all modules to new Zscaler RHEL9 Images ([#18](#18)) ([af49827](af49827))
|
This PR is included in version 1.5.0 🎉 |
~> IMPORTANT Starting on upcoming version 1.5.0 of this module, all App Connectors are deployed using the new Red Hat Enterprise Linux 9