Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

oh-my-zsh plugin naming #101

Open
jjangga0214 opened this issue Apr 9, 2019 · 1 comment
Open

oh-my-zsh plugin naming #101

jjangga0214 opened this issue Apr 9, 2019 · 1 comment
Labels

Comments

@jjangga0214
Copy link

jjangga0214 commented Apr 9, 2019

README.md says to add oh-my-zsh plugin with name of history-substring-search. However, this is inconsistent with zsh-users' other plugins, such as zsh-completions, zsh-syntax-highlighting and zsh-autosuggestions, which are all prefixed by zsh and have same name with their repositories.

And actually, specifying its name as zsh-history-substring-search also works.

So, why not change it? Is it due to some historical reason?

@sunaku
Copy link
Member

sunaku commented May 13, 2019

Yes, that is correct! 👍 The plugin name originally included a "zsh-" prefix in #87, but it was later changed to remove the "zsh-" prefix in #91 because the prefix was causing installation problems for a user (@beheist).

If you can confirm that it's no longer a problem, please submit a PR that restores the "zsh-" prefix. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants