Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature Request] Use thumbnails directly from song metadata #118

Closed
ghost opened this issue Apr 4, 2023 · 11 comments
Closed

[Feature Request] Use thumbnails directly from song metadata #118

ghost opened this issue Apr 4, 2023 · 11 comments
Labels
state: done Has been fixed or implemented type: enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Apr 4, 2023

Screenshot_20230404-121958_Symphony~2.jpg

@zyrouge
Copy link
Owner

zyrouge commented Apr 4, 2023

It might take some time for Media Store to cache them. This should get fixed automatically.

@ghost
Copy link
Author

ghost commented Apr 4, 2023

Do I need to stay on the app for it to get cached ?

@zyrouge
Copy link
Owner

zyrouge commented Apr 5, 2023

Nope, it is handled by Android itself.

@ghost
Copy link
Author

ghost commented Apr 5, 2023

Do we have a way of using the thumbnails already saved in the song file instead of using the Media Store.

@zyrouge
Copy link
Owner

zyrouge commented Apr 5, 2023

Media Store uses the embedded album and cache it for use. Maybe it's time to not rely on Media Store for thumbnails.

@ghost
Copy link
Author

ghost commented Apr 5, 2023

Yeah I think so to. Plus I saw on an other music app that it's not 100% reliable

@zyrouge zyrouge changed the title Thumbnails do not show up. [Feature Request] Use thumbnails directly from song metadata Apr 6, 2023
@zyrouge zyrouge added type: enhancement New feature or request priority: medium Medium priority labels Apr 6, 2023
@zyrouge
Copy link
Owner

zyrouge commented Apr 6, 2023

This comes with the cost of caching all the covers of the songs in the library which is really inefficient and high in memory consumption depending on the size of the library.

@zyrouge zyrouge added priority: medium Medium priority and removed priority: medium Medium priority labels Apr 6, 2023
@ghost
Copy link
Author

ghost commented Apr 6, 2023

Smartphones are getting better every years and that other music apps already use this feature, I think it can be possible.

If I look like a dummy saying things it's because I'm not currently a developper.

@zyrouge zyrouge added this to the v110 milestone Dec 30, 2023
@zyrouge zyrouge added priority: high High priority and removed priority: medium Medium priority labels Jan 2, 2024
@zyrouge zyrouge modified the milestones: v110, v111 Mar 17, 2024
@shynline
Copy link
Contributor

shynline commented Apr 7, 2024

Are you working on this? @zyrouge
If not i'll open a PR and we can discuss about it.

@zyrouge
Copy link
Owner

zyrouge commented Apr 7, 2024

Are you working on this? @zyrouge If not i'll open a PR and we can discuss about it.

Don't work on this yet. The better way to solve this would be implementing custom metadata decoders, which will be implemented in the next update or two.

@zyrouge zyrouge modified the milestones: v111, v112 Apr 20, 2024
@Wjxfi
Copy link

Wjxfi commented Nov 3, 2024

Thank you

@zyrouge zyrouge added state: done Has been fixed or implemented and removed priority: high High priority labels Nov 14, 2024
@zyrouge zyrouge closed this as completed Nov 14, 2024
@zyrouge zyrouge reopened this Nov 14, 2024
@zyrouge zyrouge closed this as completed Nov 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
state: done Has been fixed or implemented type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants