Skip to content
This repository was archived by the owner on Jul 19, 2024. It is now read-only.

Get-JenkinsUserFullName #4

Merged
merged 6 commits into from
Jun 11, 2019
Merged

Get-JenkinsUserFullName #4

merged 6 commits into from
Jun 11, 2019

Conversation

zionyx
Copy link
Contributor

@zionyx zionyx commented Jun 7, 2019 •
edited
Loading

Added cmdlet,

  • Private: Get-JenkinsUserInfo.ps1
  • Public: Get-JenkinsUserFullName.ps1
  • Tests, Get-JenkinsUserFullName.Test.ps1.

@zionyx zionyx requested a review from a team June 7, 2019 11:15
@zionyx zionyx force-pushed the Get-JenkinsUserFullName branch from c3edc68 to fdc8d61 Compare June 7, 2019 11:17
jetersen
jetersen suggested changes Jun 7, 2019
View reviewed changes
@zionyx zionyx force-pushed the Get-JenkinsUserFullName branch from 7fff0d4 to b860f08 Compare June 7, 2019 11:51
@zionyx zionyx force-pushed the Get-JenkinsUserFullName branch from b860f08 to bbfe0d5 Compare June 7, 2019 12:12
jetersen
jetersen approved these changes Jun 7, 2019
View reviewed changes
Copy link

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mighty fine! 🙌

jetersen
jetersen suggested changes Jun 7, 2019
View reviewed changes
Copy link

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit authoring looks funky

@zionyx
Copy link
Contributor Author

zionyx commented Jun 7, 2019

Your commit authoring looks funky

https://www.youtube.com/watch?v=QxBC7ol-iUs

rasmusjelsgaard
rasmusjelsgaard previously requested changes Jun 7, 2019
View reviewed changes
@zionyx
Copy link
Contributor Author

zionyx commented Jun 11, 2019

Thanks @Casz !

@zionyx zionyx requested a review from Sisha1980 June 11, 2019 11:02
@zionyx zionyx merged commit 15f0195 into master Jun 11, 2019
@jetersen jetersen deleted the Get-JenkinsUserFullName branch June 11, 2019 11:27
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jetersen jetersen jetersen approved these changes

@rasmusjelsgaard rasmusjelsgaard Awaiting requested review from rasmusjelsgaard

@Sisha1980 Sisha1980 Awaiting requested review from Sisha1980

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zionyx @jetersen @rasmusjelsgaard @lee-at-work