Skip to content

Adds show / hide delay #173

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adds show / hide delay #173

wants to merge 3 commits into from

Conversation

nicysneiros
Copy link

This PR adds tooltip-show-delay and tooltip-hide-delay attributes do the directive. These attr expect a number value expressing the delay time (in milliseconds) to show / hide the tooltip. The delay is implemented by adding $timeout to the function that adds / removes the class "active" to / from the tooltip. The readme is updated with these attributes.

This PR solves issue #153.

@45kb
Copy link
Member

45kb commented Jul 30, 2016

Hi @nicysneiros this is a stunning work you've done.

Only the problem is $timeout, which is too much heavy (specially if you are using multiple tooltips on a page).

As you can see in the CSS file, there are simple classes that applies fade effect on tooltip, so delays should be done via CSS animation delay and not via $timeout 👍

If you can make this changes we we'll merge it, thanks!!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants