-
Notifications
You must be signed in to change notification settings - Fork 32
Fix xpk workload create
for L4 and A100
#452
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
xpk workload create
for L4 and A100
Are we running tests for L4 gpus? they are pretty available imo |
I don't think so. Should I make a task for it? |
Imo, it would be nice to have it as part of this task, to be sure that L4 is supported and that the fix is indeed working. |
Agreed, it would be nice. But it does not look so simple to implement, we would have to parallelize tests and I'm not sure I can squeeze it in here. The goal of this task was to simply fix the error. Let's do the test refactoring in another one. |
I think we can just add another device type on the list where you can choose devices and run it from there. No need to run it each time for now. |
Fixes / Features
xpk workload create
for L4 and A100 machines