Skip to content

Fix xpk workload create for L4 and A100 #452

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Apr 14, 2025
Merged

Fix xpk workload create for L4 and A100 #452

merged 7 commits into from
Apr 14, 2025

Conversation

gcie
Copy link
Collaborator

@gcie gcie commented Apr 9, 2025

Fixes / Features

  • xpk workload create for L4 and A100 machines

@gcie gcie self-assigned this Apr 9, 2025
@gcie gcie changed the title Fix workload creation for L4 and A100 Fix xpk workload create for L4 and A100 Apr 9, 2025
@gcie gcie marked this pull request as ready for review April 9, 2025 13:39
@pawloch00
Copy link
Collaborator

Are we running tests for L4 gpus? they are pretty available imo

@gcie
Copy link
Collaborator Author

gcie commented Apr 11, 2025

Are we running tests for L4 gpus? they are pretty available imo

I don't think so. Should I make a task for it?

@pawloch00
Copy link
Collaborator

Are we running tests for L4 gpus? they are pretty available imo

I don't think so. Should I make a task for it?

Imo, it would be nice to have it as part of this task, to be sure that L4 is supported and that the fix is indeed working.

@gcie
Copy link
Collaborator Author

gcie commented Apr 11, 2025

Are we running tests for L4 gpus? they are pretty available imo

I don't think so. Should I make a task for it?

Imo, it would be nice to have it as part of this task, to be sure that L4 is supported and that the fix is indeed working.

Agreed, it would be nice. But it does not look so simple to implement, we would have to parallelize tests and I'm not sure I can squeeze it in here. The goal of this task was to simply fix the error. Let's do the test refactoring in another one.

@pawloch00
Copy link
Collaborator

I think we can just add another device type on the list where you can choose devices and run it from there. No need to run it each time for now.

@gcie gcie requested a review from pawloch00 April 14, 2025 06:59
@gcie gcie enabled auto-merge (squash) April 14, 2025 08:48
@gcie gcie merged commit 735bbc1 into develop Apr 14, 2025
28 of 29 checks passed
@gcie gcie deleted the gpu-workloads-fix branch April 14, 2025 11:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants