Skip to content

Update MaxText commands #454

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

Update MaxText commands #454

merged 2 commits into from
Apr 14, 2025

Conversation

SurbhiJainUSC
Copy link
Collaborator

Fixes / Features

Testing / Documentation

Testing details.

  • [ y/n ] Tests pass
  • [ y ] Appropriate changes to documentation are included in the PR

Obliviour
Obliviour previously approved these changes Apr 11, 2025
View reviewed changes
RoshaniN
RoshaniN previously approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@RoshaniN RoshaniN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Surbhi, suggested a small change!

@SurbhiJainUSC SurbhiJainUSC dismissed stale reviews from RoshaniN and Obliviour via d971985 April 11, 2025 22:47
RoshaniN
RoshaniN approved these changes Apr 14, 2025
View reviewed changes
@SurbhiJainUSC SurbhiJainUSC enabled auto-merge (squash) April 14, 2025 18:15
@SurbhiJainUSC SurbhiJainUSC merged commit 709ac80 into main Apr 14, 2025
15 checks passed
@SurbhiJainUSC SurbhiJainUSC deleted the maxtext-refactor-fix branch April 14, 2025 18:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shralex shralex shralex approved these changes

@RoshaniN RoshaniN RoshaniN approved these changes

@bvandermoon bvandermoon bvandermoon approved these changes

@Obliviour Obliviour Obliviour left review comments

@44past4 44past4 Awaiting requested review from 44past4 44past4 is a code owner

@sharabiani sharabiani Awaiting requested review from sharabiani sharabiani is a code owner

@pawloch00 pawloch00 Awaiting requested review from pawloch00 pawloch00 is a code owner

@BluValor BluValor Awaiting requested review from BluValor BluValor is a code owner

@gcie gcie Awaiting requested review from gcie gcie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SurbhiJainUSC @shralex @RoshaniN @Obliviour @bvandermoon