Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes google # button #253

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

Chalhotra
Copy link
Contributor

Description

This PR fixes the minor issue of the google # button looking weird on hovering, mostly on the web based flutter app

Fixes #231

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

Since this is a purely UI change, it doesn't affect functionality, and it has anyways been tested manually on both mobile and web apps

Please include screenshots below if applicable.

Screenshot 2025-02-02 at 7 14 10 PM

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [x ] My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

Chalhotra and others added 2 commits December 27, 2024 21:55
…SignInButton from flutter_sign_in_button package, refactors CustomElevatedButton
@Chalhotra Chalhotra requested a review from jddeep as a code owner February 2, 2025 13:51
@mdmohsin7
Copy link
Member

Pls resolve the conflicts @Chalhotra

@Chalhotra
Copy link
Contributor Author

done

@mdmohsin7 mdmohsin7 merged commit 6ff9809 into AOSSIE-Org:develop Feb 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google # button on hovering looks weird
2 participants