Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: improve password visibility, input-field focus & keyboard flow #254

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

navaneeth0041
Copy link
Contributor

Description

This PR addresses multiple UX issues in the LoginViewMobile page by improving password security, keyboard behavior, and form navigation:

  1. Password Field Fixes:

    • Password field was visible by default instead of being obscured (security concern)
    • Now properly starts in a hidden state with a working visibility toggle
  2. Keyboard and Focus Improvements:

    • On-screen keyboard was overlapping input fields, making text entry difficult
    • Improved form navigation: pressing 'Next' now moves focus to the next field instead of dismissing the keyboard
    • Ensured smooth scrolling and proper focus handling when switching between fields

Fixes #248

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The following test scenarios were performed on a mobile device:

  1. Password Field Testing:

    • Verified password field starts obscured by default
    • Tested visibility toggle button functionality
  2. Keyboard & Focus Testing:

    • Ensured keyboard does not overlap active input fields
    • Verified smooth transition between fields when pressing 'Next'
    • Checked that the keyboard remains open while navigating through form fields
WhatsApp.Video.2025-02-05.at.22.13.14.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@navaneeth0041 navaneeth0041 requested a review from jddeep as a code owner February 5, 2025 16:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant