Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implemented image uploading on web #255

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

xkaper001
Copy link
Contributor

@xkaper001 xkaper001 commented Feb 8, 2025

fixes #239

Description

Introduce functionality for uploading images, including profile pictures, by utilizing byte data instead of file objects. Update relevant components to handle image bytes and improve image display methods. Now, Uploading images works on the web as well.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This has been tested on Chrome web browser and a physical Android device as well.

Preview/Screenshots

issue239.-.Made.with.Clipchamp.mp4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@xkaper001 xkaper001 requested a review from jddeep as a code owner February 8, 2025 20:55
@xkaper001 xkaper001 changed the title implemented image uploading on web Implemented image uploading on web Feb 8, 2025
@mdmohsin7
Copy link
Member

Will the uploading functionality work as expected on other platforms?

@xkaper001
Copy link
Contributor Author

Yes, @mdmohsin7 this isn't platform dependant and works on all platforms.

Copy link
Member

@mdmohsin7 mdmohsin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdmohsin7 mdmohsin7 merged commit cf83070 into AOSSIE-Org:develop Mar 2, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Uploading images not implemented on web
2 participants