Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix windows paths and external refs #321

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Fix windows paths and external refs #321

merged 5 commits into from
Sep 19, 2023

Conversation

jonluca
Copy link
Collaborator

@jonluca jonluca commented Sep 18, 2023

Adding in the code to fix some path issues and some relative paths.

This doesn't fully address #200 - we really need a more updated test schema.

I imported a majority of the code from that PR, though, and will take a look at some point in the future.

#315 windows absolute paths should be included here

@coveralls
Copy link

coveralls commented Sep 18, 2023

Pull Request Test Coverage Report for Build 6228842548

  • 57 of 69 (82.61%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 95.973%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/util/convert-path-to-posix.ts 9 11 81.82%
lib/util/url.ts 28 38 73.68%
Totals Coverage Status
Change from base Build 4069430371: 0.2%
Covered Lines: 3202
Relevant Lines: 3294

💛 - Coveralls

@jonluca jonluca changed the title Fix windows paths Fix windows paths and external refs Sep 18, 2023
@jonluca jonluca enabled auto-merge (squash) September 18, 2023 22:51
Copy link

@sukeshpabolu sukeshpabolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@jonluca jonluca merged commit b9f91b2 into main Sep 19, 2023
@jonluca jonluca deleted the feat/win-paths branch September 19, 2023 23:41
@github-actions
Copy link

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants