Fix iOS touch issue on v-close-popper #1077
Conversation
caused by touchstart passive option
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @navyCarpet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue where the v-close-popper directive, when applied to a router-link on iOS devices, would only close the popper without navigating to the new page. The fix involves conditionally disabling the touchstart event listener based on whether the device is running iOS.
Highlights
- Bug Fix: Addresses an issue where
v-close-popperprevented navigation on iOS devices when used withrouter-link. - Conditional Event Listener: The
touchstartevent listener is now conditionally added based on whether the device is running iOS.
Changelog
- packages/floating-vue/src/directives/v-close-popper.ts
- Imported
isIOSfrom../util/env. - Conditionally disabled the
touchstartevent listener on iOS devices by adding!isIOSto the conditionsupportsPassive && !isIOSon line 6.
- Imported
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
On iOS, a tap's delay,
A popper closed, the page astray.
With nimble fix,
Navigation mix,
Now routes work without dismay.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This PR addresses an issue where the v-close-popper directive, when used on a router-link, would only close the popper without navigating page on iOS. The solution involves conditionally applying the passive listener option based on whether the device is an iOS device. This seems like a reasonable approach to address the reported issue.
Merge Readiness
The code change appears straightforward and addresses the described issue. Given the targeted fix for iOS and the use of feature detection (isIOS), the risk of unintended side effects seems low. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. The change seems reasonable and I would recommend merging it after another review.
✅ Deploy Preview for v-tooltip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Another way could be to add modifiers that disable the passive. I look forward to comment. |
This PR fixes an issue where the
v-close-popperdirective, when used on arouter-link, would only close the popper without navigating page on iOS.