Skip to content

Feat/webpack5 #4

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 8 commits into
base: feat/webpack5
Choose a base branch
from
Open

Feat/webpack5 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1025270
fix: node_module resolution when using relative packages
rigor789 Apr 1, 2021
fb2c291
feat: look for loaders in project node_modules first
rigor789 Apr 1, 2021
7edb1e9
fix: copy stubs step
rigor789 Apr 1, 2021
1627f52
feat: warnOnce & graceful error handling
rigor789 Apr 1, 2021
d8067a5
fix: resolving loaders from non-hoisted deps
rigor789 Apr 2, 2021
6e0f462
update svelte config to use svelte-loader
halfnelson Apr 5, 2021
88a7ced
handle null config
halfnelson Apr 5, 2021
2783b30
fix: worker support in .svelte files & update snapshots
rigor789 Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/webpack5/__tests__/configuration/__snapshots__/angular.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,16 @@ exports[`angular configuration for android 1`] = `
mainFields: [
'module',
'main'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down Expand Up @@ -349,11 +354,16 @@ exports[`angular configuration for ios 1`] = `
mainFields: [
'module',
'main'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down
14 changes: 12 additions & 2 deletions packages/webpack5/__tests__/configuration/__snapshots__/base.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,16 @@ exports[`base configuration for android 1`] = `
'.scss',
'.android.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down Expand Up @@ -329,11 +334,16 @@ exports[`base configuration for ios 1`] = `
'.scss',
'.ios.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down
14 changes: 12 additions & 2 deletions packages/webpack5/__tests__/configuration/__snapshots__/javascript.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,16 @@ exports[`javascript configuration for android 1`] = `
'.scss',
'.android.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down Expand Up @@ -367,11 +372,16 @@ exports[`javascript configuration for ios 1`] = `
'.scss',
'.ios.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down
28 changes: 24 additions & 4 deletions packages/webpack5/__tests__/configuration/__snapshots__/react.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,16 @@ exports[`react configuration > android > adds ReactRefreshWebpackPlugin when HMR
'.scss',
'.android.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down Expand Up @@ -360,11 +365,16 @@ exports[`react configuration > android > base config 1`] = `
'.scss',
'.android.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down Expand Up @@ -652,11 +662,16 @@ exports[`react configuration > ios > adds ReactRefreshWebpackPlugin when HMR ena
'.scss',
'.ios.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down Expand Up @@ -967,11 +982,16 @@ exports[`react configuration > ios > base config 1`] = `
'.scss',
'.ios.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down
50 changes: 32 additions & 18 deletions packages/webpack5/__tests__/configuration/__snapshots__/svelte.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exports[`svelte configuration for android 1`] = `
'~/package.json'
],
devtool: 'inline-source-map',
target: 'node',
target: 'electron-main',
watchOptions: {
ignored: [
'__jest__/platforms/**',
Expand All @@ -30,7 +30,8 @@ exports[`svelte configuration for android 1`] = `
symlinks: true,
alias: {
'~': '__jest__/src',
'@': '__jest__/src'
'@': '__jest__/src',
'tns-core-modules': '@nativescript/core'
},
extensions: [
'.android.svelte',
Expand All @@ -45,11 +46,16 @@ exports[`svelte configuration for android 1`] = `
'.scss',
'.android.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down Expand Up @@ -117,7 +123,7 @@ exports[`svelte configuration for android 1`] = `
},
/* config.module.rule('workers') */
{
test: /\\\\.(js|ts)$/,
test: /\\\\.(js|ts|svelte)$/,
exclude: [
/node_modules/
],
Expand Down Expand Up @@ -189,18 +195,19 @@ exports[`svelte configuration for android 1`] = `
/node_modules/
],
use: [
/* config.module.rule('svelte').use('svelte-loader-hot') */
/* config.module.rule('svelte').use('svelte-loader') */
{
loader: 'svelte-loader-hot',
loader: 'svelte-loader',
options: {
dev: true,
compilerOptions: {
dev: true
},
preprocess: undefined,
hotReload: true,
hotOptions: {
injectCss: false,
'native': true
},
onwarn: function () { /* omitted long function */ }
}
}
}
]
Expand Down Expand Up @@ -319,7 +326,7 @@ exports[`svelte configuration for ios 1`] = `
'~/package.json'
],
devtool: 'inline-source-map',
target: 'node',
target: 'electron-main',
watchOptions: {
ignored: [
'__jest__/platforms/**',
Expand All @@ -341,7 +348,8 @@ exports[`svelte configuration for ios 1`] = `
symlinks: true,
alias: {
'~': '__jest__/src',
'@': '__jest__/src'
'@': '__jest__/src',
'tns-core-modules': '@nativescript/core'
},
extensions: [
'.ios.svelte',
Expand All @@ -356,11 +364,16 @@ exports[`svelte configuration for ios 1`] = `
'.scss',
'.ios.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down Expand Up @@ -428,7 +441,7 @@ exports[`svelte configuration for ios 1`] = `
},
/* config.module.rule('workers') */
{
test: /\\\\.(js|ts)$/,
test: /\\\\.(js|ts|svelte)$/,
exclude: [
/node_modules/
],
Expand Down Expand Up @@ -500,18 +513,19 @@ exports[`svelte configuration for ios 1`] = `
/node_modules/
],
use: [
/* config.module.rule('svelte').use('svelte-loader-hot') */
/* config.module.rule('svelte').use('svelte-loader') */
{
loader: 'svelte-loader-hot',
loader: 'svelte-loader',
options: {
dev: true,
compilerOptions: {
dev: true
},
preprocess: undefined,
hotReload: true,
hotOptions: {
injectCss: false,
'native': true
},
onwarn: function () { /* omitted long function */ }
}
}
}
]
Expand Down
14 changes: 12 additions & 2 deletions packages/webpack5/__tests__/configuration/__snapshots__/typescript.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,16 @@ exports[`typescript configuration for android 1`] = `
'.scss',
'.android.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down Expand Up @@ -367,11 +372,16 @@ exports[`typescript configuration for ios 1`] = `
'.scss',
'.ios.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down
14 changes: 12 additions & 2 deletions packages/webpack5/__tests__/configuration/__snapshots__/vue.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,16 @@ exports[`vue configuration for android 1`] = `
'.scss',
'.android.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down Expand Up @@ -364,11 +369,16 @@ exports[`vue configuration for ios 1`] = `
'.scss',
'.ios.json',
'.json'
],
modules: [
'__jest__/node_modules',
'node_modules'
]
},
resolveLoader: {
modules: [
'node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules/@nativescript/webpack/dist/loaders',
'__jest__/node_modules',
'node_modules'
]
},
Expand Down
Loading