Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

🔥 Remove notch #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

🔥 Remove notch #2

wants to merge 2 commits into from

Conversation

she11sh0cked
Copy link

This fixes #1

@AlynxZhou
Copy link
Owner

I suggest to let Apple remove their ugly notch first!

@justinkb
Copy link

LGTM

bobby285271
bobby285271 approved these changes Oct 23, 2021
View reviewed changes
Copy link

@bobby285271 bobby285271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@draco892
Copy link

I love you guys XD

@AlynxZhou AlynxZhou added the wontfix This will not be worked on label Oct 29, 2021
@AlynxZhou
Copy link
Owner

Refer: https://github.com/kelseyhightower/nocode

@she11sh0cked
Copy link
Author

Merged from upstream to resolve the conflicts. Waiting for review.

gitlimes
gitlimes approved these changes Nov 1, 2021
View reviewed changes
Copy link

@gitlimes gitlimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gitlimes gitlimes gitlimes approved these changes

@ItzSwirlz ItzSwirlz ItzSwirlz approved these changes

@bobby285271 bobby285271 bobby285271 approved these changes

Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Notch
7 participants
@she11sh0cked @AlynxZhou @justinkb @draco892 @bobby285271 @ItzSwirlz @gitlimes