Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update resource API versions and improve naming conventions #37

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

segraef
Copy link

@segraef segraef commented Feb 28, 2025

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@segraef segraef requested a review from ckittel April 3, 2025 22:40
@segraef
Copy link
Author

segraef commented Apr 3, 2025

Copy link
Author

@segraef segraef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@@ -189,8 +183,6 @@ resource aiHub 'Microsoft.MachineLearningServices/workspaces@2024-07-01-preview'
authType: 'AAD'
category: 'AzureOpenAI'
isSharedToAll: true
useWorkspaceManagedIdentity: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without useWorkspaceManagedIdentity: true how does the workspace's managed identity get selected to be used? The default for this is false, it was intentional to set this to true to be explicit.

@@ -189,8 +183,6 @@ resource aiHub 'Microsoft.MachineLearningServices/workspaces@2024-07-01-preview'
authType: 'AAD'
category: 'AzureOpenAI'
isSharedToAll: true
useWorkspaceManagedIdentity: true
peRequirement: 'NotRequired'
Copy link
Member

@ckittel ckittel Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove peRequirement? This was us being explicit for the "basic" implementation here to show that we don't expect a private endpoint based connection.

Comment on lines 162 to 164
ipAllowlist: []
serverlessComputeSettings: null
enableServiceSideCMKEncryption: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did these three get removed?

Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating API versions and applying some formatting changes.

Before I merge, I'll wait to hear from @segraef -- as he let me know that the latest test had a failure due to something related to a network monitor in Australia east.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants