-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: update resource API versions and improve naming conventions #37
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
…hanced functionality
Deployment was tested here: https://github.com/Azure/data-ai-solutions-lab/actions/runs/14254281437/job/39953877367 ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
@@ -189,8 +183,6 @@ resource aiHub 'Microsoft.MachineLearningServices/workspaces@2024-07-01-preview' | |||
authType: 'AAD' | |||
category: 'AzureOpenAI' | |||
isSharedToAll: true | |||
useWorkspaceManagedIdentity: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without useWorkspaceManagedIdentity: true
how does the workspace's managed identity get selected to be used? The default for this is false
, it was intentional to set this to true
to be explicit.
@@ -189,8 +183,6 @@ resource aiHub 'Microsoft.MachineLearningServices/workspaces@2024-07-01-preview' | |||
authType: 'AAD' | |||
category: 'AzureOpenAI' | |||
isSharedToAll: true | |||
useWorkspaceManagedIdentity: true | |||
peRequirement: 'NotRequired' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we remove peRequirement
? This was us being explicit for the "basic" implementation here to show that we don't expect a private endpoint based connection.
ipAllowlist: [] | ||
serverlessComputeSettings: null | ||
enableServiceSideCMKEncryption: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did these three get removed?
…ecurity and management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating API versions and applying some formatting changes.
Before I merge, I'll wait to hear from @segraef -- as he let me know that the latest test had a failure due to something related to a network monitor in Australia east.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information