Skip to content

fix: create a new controller before dispose, cause loop request when … #59

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chalecao
Copy link

@chalecao chalecao commented Sep 19, 2023

hi, this is my case.

sometimes, call create before dispose when caught exception, but curRequestController get a new AbortController, so it doesn't work.

async function create() {
  curRequestController = new AbortController();
  try {
    ....
   } catch (err) {
       retryTimer = window.setTimeout(create, interval);
       dispose();
  }

so , i fixed it by use origin curRequestController first:

curRequestController = curRequestController || new AbortController();

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant