Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat!: renamed package geocoding_ios to geocoding_darwin #245

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

OutdatedGuy
Copy link
Contributor

Renames geocoding_ios to geocoding_darwin to later add macOS support. Will follow up with macOS support PR after this is merged.

resolves #244

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@OutdatedGuy
Copy link
Contributor Author

@mvanbeusekom @JeroenWeener can you guys review this PR?

@OutdatedGuy OutdatedGuy force-pushed the refactor/rename-ios-to-darwin branch from 512f153 to 5b94e80 Compare October 8, 2024 00:35
@martijn00 martijn00 requested a review from mvanbeusekom October 8, 2024 08:26
@martijn00
Copy link
Collaborator

@OutdatedGuy can you do a rebase on this PR?

@OutdatedGuy OutdatedGuy force-pushed the refactor/rename-ios-to-darwin branch from 94239b0 to 9672221 Compare October 8, 2024 11:10
@OutdatedGuy
Copy link
Contributor Author

OutdatedGuy commented Oct 8, 2024

@OutdatedGuy can you do a rebase on this PR?

@martijn00 Done ✅

@OutdatedGuy OutdatedGuy force-pushed the refactor/rename-ios-to-darwin branch from 9672221 to bfa7463 Compare October 11, 2024 00:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Rename package geocoding_ios to geocoding_darwin
2 participants