Remove < iOS 11 fallback API calls in openSettings:

[jmagman]

geolocator_apple runs on a minimum of iOS 11

flutter-geolocator/geolocator_apple/ios/geolocator_apple.podspec

Line 20 in df61d4c

s.platform = :ios, '11.0'

This means that if (@available(iOS 10, *)) will never be false. Remove the dead fallback. See my explanation in #1652 (comment) why I'm limiting the availability cleanup to this one -[UIApplication openURL:] method.

Remove fallbacks in tests as well.

On this PR:

Test Case '-[GeolocatorPluginTests testOpenAppSettings]' started.
Test Case '-[GeolocatorPluginTests testOpenAppSettings]' passed (0.001 seconds).

Part of #1652

Pre-launch Checklist

• I made sure the project builds.
• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
• I updated CHANGELOG.md to add a description of the change.
• I updated/added relevant documentation (doc comments with ///).
• I rebased onto main.
• I added new tests to check the change I am making, or this PR does not need tests.
• I made sure all existing and new tests are passing.
• I ran dart format . and committed any changes.
• I ran flutter analyze and fixed any errors.

[jmagman]

Note this PR is easier to read with whitespace ignored:

[jmagman]

Happy to bump the version if you prefer, up to you!

[TimHoogstrate]

@jmagman would be great. Thanks. Since I have not released 2.3.10 yet, I prefer it to be added to 2.3.10, since that is just a relative minor (update) release.

[TimHoogstrate]

@jmagman, When I check the gelocator_apple package It looks like i see some more @available(iOS below or 11) Could we not clean it all?

Kind regards,

[mvanbeusekom]

@jmagman, When I check the gelocator_apple package It looks like i see some more @available(iOS below or 11) Could we not clean it all?

Kind regards,

I think that would be a good idea, however maybe we can do so in a separate PR and start releasing this so the Flutter team can continue there work on the linter rule.

[TimHoogstrate]

@jmagman,

I've updated the version number and merged your changes. Thanks for your help. Your support is truly appreciated.

Kind regards,

[jmagman]

Thank you @TimHoogstrate for handling that!