Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds MacOS Support #1207

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Adds MacOS Support #1207

wants to merge 19 commits into from

Conversation

alex-melnyk
Copy link

@alex-melnyk alex-melnyk commented Nov 2, 2023

This PR replaces this one for macOS platform support.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

This PR is fixes for comments of:
#946

@dkbast
Copy link

dkbast commented Dec 14, 2023

@mvanbeusekom is there anything I can do to help move this forward? @alex-melnyk I think the pipeline is now broken because of some deprecated material fields in the example app

@alex-melnyk
Copy link
Author

Yes, please help me fix the pipeline

@dkbast
Copy link

dkbast commented Dec 14, 2023

@alex-melnyk I think I cant directly contribute here, but I fixed the warnings over at alex-melnyk#1

@shubhamsinghshubham777
Copy link

shubhamsinghshubham777 commented Dec 30, 2023

@alex-melnyk I think I cant directly contribute here, but I fixed the warnings over at alex-melnyk#1

@mvanbeusekom Are we waiting for anything else here? Seems like alex-melnyk#1 has fixed all warnings ✅ Could you please review it?

In the meantime, is there a way I could temporarily use alex-melnyk#1 in my current project?

Writing the following in pubspec.yaml doesn't work ❌

permission_handler:
    git: https://github.com/dkbast/flutter-permission-handler.git

@dkbast
Copy link

dkbast commented Dec 31, 2023

I believe you need to either add ref: main or remove the .git in the url

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.42%. Comparing base (78a549c) to head (a6ef4a5).
Report is 39 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   71.42%   71.42%           
=======================================
  Files           1        1           
  Lines          35       35           
=======================================
  Hits           25       25           
  Misses         10       10           
Flag Coverage Δ
unittests 71.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex-melnyk
Copy link
Author

@alex-melnyk I think I cant directly contribute here, but I fixed the warnings over at alex-melnyk#1

@mvanbeusekom Are we waiting for anything else here? Seems like alex-melnyk#1 has fixed all warnings ✅ Could you please review it?

In the meantime, is there a way I could temporarily use alex-melnyk#1 in my current project?

Writing the following in pubspec.yaml doesn't work ❌

permission_handler:
    git: https://github.com/dkbast/flutter-permission-handler.git

You need to override dependencies to use your implementation, here is example:

dependency_overrides:
  # https://github.com/Baseflow/flutter-permission-handler/pull/1207
  permission_handler:
    git:
      url: git@github.com:alex-melnyk/flutter-permission-handler.git
      path: permission_handler
      ref: master
  # https://github.com/Baseflow/flutter-permission-handler/pull/1207
  permission_handler_apple:
    git:
      url: git@github.com:alex-melnyk/flutter-permission-handler.git
      path: permission_handler_apple
      ref: master

@alex-melnyk
Copy link
Author

@alex-melnyk I think I cant directly contribute here, but I fixed the warnings over at alex-melnyk#1

Thank you for the support!

@subygan
Copy link

subygan commented Mar 9, 2024

@mvanbeusekom bumping this up, as this PR would really help fixing a hole in the ecosystem, in terms of compatibility.

@hifiaz
Copy link

hifiaz commented Mar 28, 2024

hi @alex-melnyk what do you think about permission CGPreflightScreenCaptureAccess and request CGRequestScreenCaptureAccess on macos? i search reference about this on flutter but still not found, so i use MethodChannel to request that

@Rileyjrjohns
Copy link

@mvanbeusekom Hello, could you please review this PR ? It's a really important features. Thanks :)

@efraespada
Copy link

Please, push it.

@Rileyjrjohns
Copy link

@mvanbeusekom up please

@FXschwartz
Copy link

@mvanbeusekom Any chance you have any bandwidth to take a look a this PR?

@MichalNemec
Copy link

@mvanbeusekom This is crutial for our application, waiting now for around 6 months for this to be merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants