Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed crashing on machines with early windows 10 version #1389

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

krll-kov
Copy link

Fixed following issue: #1388

Pre-launch Checklist

  • [+] I made sure the project builds.
  • [+] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [+] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is does not need version changes.
  • [+] I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@krll-kov
Copy link
Author

@mvanbeusekom can you review it please?

@mvanbeusekom mvanbeusekom self-assigned this Nov 18, 2024
Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krll-kov,

First of all thank you very much for this contribution and apologies for the late reply.

I am hoping you are still willing to contribute, I have reviewed the PR and have some feedback that would be great if you can address (especially since I don't have access to an early Windows 10 machine).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants