Await futures in emptyCache #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
contactjavas
added a commit
to tentram/flutter_cache_manager
that referenced
this pull request
Sep 18, 2023
|
Is there a timeline for when this will be reviewed? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Hard to say, sort of a bug fix.
Currently when you empty the cache, even if you await it, some of the work happens out of band.
🆕 What is the new behavior (if this is a feature change)?
When you empty the cache and await it, all the underlying functionality is awaited as well.
💥 Does this PR introduce a breaking change?
A little. Callers may be used to this call being quick, now it will take a bit longer. Users who prefer the previous behaviour should likely stop awaiting the future. This is generally preferred and standard; awaiting a future should actually await all the underlying functionality and if a user doesn't want to wait for that, they just don't await it.
🐛 Recommendations for testing
I've tested this locally but can test further if requested.
📝 Links to relevant issues/docs
No issue that I'm aware of.
🤔 Checklist before submitting