Skip to content

Set ImageRenderMethodForWeb.HttpGet, as a default imageRenderMethodForWeb for flutter 3.27.0 compatibility workaround #996

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ import FlutterMacOS
import Foundation

import path_provider_foundation
import sqflite
import sqflite_darwin
import url_launcher_macos

func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
2 changes: 1 addition & 1 deletion cached_network_image/lib/src/cached_image_widget.dart
Original file line number Diff line number Diff line change
@@ -240,7 +240,7 @@ class CachedNetworkImage extends StatelessWidget {
this.maxHeightDiskCache,
this.errorListener,
ImageRenderMethodForWeb imageRenderMethodForWeb =
ImageRenderMethodForWeb.HtmlImage,
ImageRenderMethodForWeb.HttpGet,
double scale = 1.0,
}) : _image = CachedNetworkImageProvider(
imageUrl,
Original file line number Diff line number Diff line change
@@ -2,12 +2,12 @@ import 'dart:async' show Future, StreamController;
import 'dart:ui' as ui show Codec;

import 'package:cached_network_image/src/image_provider/multi_image_stream_completer.dart';
import 'package:cached_network_image_platform_interface/cached_network_image_platform_interface.dart'
show ErrorListener, ImageRenderMethodForWeb;
import 'package:cached_network_image_platform_interface/cached_network_image_platform_interface.dart'
if (dart.library.io) '_image_loader.dart'
if (dart.library.js_interop) 'package:cached_network_image_web/cached_network_image_web.dart'
show ImageLoader;
import 'package:cached_network_image_platform_interface/cached_network_image_platform_interface.dart'
show ErrorListener, ImageRenderMethodForWeb;
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_cache_manager/flutter_cache_manager.dart';
@@ -28,7 +28,7 @@ class CachedNetworkImageProvider
this.headers,
this.cacheManager,
this.cacheKey,
this.imageRenderMethodForWeb = ImageRenderMethodForWeb.HtmlImage,
this.imageRenderMethodForWeb = ImageRenderMethodForWeb.HttpGet,
});

/// CacheManager from which the image files are loaded.
4 changes: 2 additions & 2 deletions cached_network_image/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ version: 3.4.1

environment:
sdk: ^3.0.0
flutter: '>=3.10.0'
flutter: ">=3.10.0"

dependencies:
cached_network_image_platform_interface: ^4.1.1
@@ -21,7 +21,7 @@ dependencies:
octo_image: ^2.1.0

dev_dependencies:
file: '>=7.0.0 <8.0.0'
file: ">=7.0.0 <8.0.0"
flutter_lints: ^4.0.0
flutter_test:
sdk: flutter
4 changes: 2 additions & 2 deletions cached_network_image_platform_interface/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -5,15 +5,15 @@ homepage: https://github.com/Baseflow/flutter_cached_network_image

environment:
sdk: ^3.0.0
flutter: '>=3.10.0'
flutter: ">=3.10.0"

dependencies:
flutter:
sdk: flutter
flutter_cache_manager: ^3.4.1

dev_dependencies:
file: '>=7.0.0 <8.0.0'
file: ">=7.0.0 <8.0.0"
flutter_lints: ^4.0.0
flutter_test:
sdk: flutter
4 changes: 2 additions & 2 deletions cached_network_image_web/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ homepage: https://github.com/Baseflow/flutter_cached_network_image

environment:
sdk: ^3.0.0
flutter: '>=3.10.0'
flutter: ">=3.10.0"

dependencies:
cached_network_image_platform_interface: ^4.1.1
@@ -15,7 +15,7 @@ dependencies:
web: ^1.0.0

dev_dependencies:
file: '>=7.0.0 <8.0.0'
file: ">=7.0.0 <8.0.0"
flutter_lints: ^4.0.0
flutter_test:
sdk: flutter