remove statics dependency from sol module #6272
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mukeshsp
force-pushed
the
sol-statics
branch
11 times, most recently
from
3c04edd to
a2815d4
Compare
mukeshsp
changed the title
| @@ -291,7 +303,8 @@ export class Transaction extends BaseTransaction { | |||
| const instructionParams = instructionParamsFactory( | |||
| this.type, | |||
| this._solTransaction.instructions, | |||
| this._coinConfig.name | |||
| this._coinConfig.name, | |||
| this._instructionsData | |||
There was a problem hiding this comment.
We may need to pass the token contract address in outputs, instructionData might not be available when building from a raw tx.
There was a problem hiding this comment.
Could you share the example ?
There was a problem hiding this comment.
Try to build a transaction from raw txHex of any unsupported token transaction, it will throw an error.
| if (!token && _useTokenAddressTokenName) { | ||
| token = mintAddress; |
There was a problem hiding this comment.
Why not pass tokenName undefined and token address as a separate fields and the populate token name and token address both in outputs.
There was a problem hiding this comment.
Since the approach was suggested by you, we can't pass the token name as undefined—these instructions are used in multiple places, which could lead to errors due to the undefined value.
Refer to the ticket description for details.
Ticket : WIN-5679