Skip to content

fix(sdk-coin-trx): fees on freeze, vote transactions #6332

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benkelcher-bitgo
Copy link
Contributor

@benkelcher-bitgo benkelcher-bitgo commented Jun 22, 2025

SC-2215

  • TODO create and link ticket
  • adds fee as a required field on the freeze and vote transactions used in the TRX staking flow
  • context: we need to require that these staking txns (and in particular the vote txn) use TRX to pay their gas fees instead of BANDWIDTH, so that our transactions generate transfers (otherwise these txns get stuck in signed on the WP side)
    • see this thread
    • longer-term it would be nice to be able to use BANDWIDTH to pay the fees

@benkelcher-bitgo benkelcher-bitgo force-pushed the ben/ton-stake-txn-fees branch from 8f3fcf9 to 124a93f Compare June 22, 2025 02:26
@benkelcher-bitgo benkelcher-bitgo changed the title fix(trx): fees on freeze, vote transactions fix(sdk-coin-trx): fees on freeze, vote transactions Jun 22, 2025
@evanzbitgo
Copy link
Contributor

Change LGTM. We might just do some tests

@Vijay-Jagannathan
Copy link
Contributor

Vijay-Jagannathan commented Jun 22, 2025

Change LGTM. We might just do some tests

@evanzbitgo I don't think we might need this since fee limit is used only for contract call txns to not burn TRX beyond a limit incase there's a high energy consumption. In our case, no energy is used + additionally, we will always burn atleast 1 TRX since its a multi-sig txn. have added more details in the slack channel

@evanzbitgo
Copy link
Contributor

Change LGTM. We might just do some tests

@evanzbitgo I don't think we might need this since fee limit is used only for contract call txns to not burn TRX beyond a limit incase there's a high energy consumption. In our case, no energy is used + additionally, we will always burn atleast 1 TRX since its a multi-sig txn. have added more details in the slack channel

I just read the conversation there https://bitgo.slack.com/archives/C0931KN7F40/p1750564616420339?thread_ts=1750560353.377609&cid=C0931KN7F40 yeah, then we might not need this. But we should test

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants