Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: docker extension removal #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Eveeifyeve
Copy link

@Eveeifyeve Eveeifyeve commented Mar 15, 2025

I added a flag because exporting in the docker container is not available.

$ docker compose exec panel export USER_CONFIRMED_REMOVAL="yes"
OCI runtime exec failed: exec failed: unable to start container process: exec: "export": executable file not found in $PATH: unknown

it is not found in /bin there should be a path /bin/export that should be there to export env, but there is not that's why it fails.

via using this docker image: https://github.com/BlueprintFramework/docker/blob/Master/docker-compose.yml

I also mentioned this in the discord I was told by @prplwtf there will be a flag implemented soon, but I need this asap so here is the pr. Link to message

by adding a flag because exporting in the docker container is not
avalible.
@Loki-101
Copy link
Collaborator

Flag aside, you can set environmental variables in a Docker container exec command: https://docs.docker.com/reference/cli/docker/container/exec/#env

Copy link
Member

@prplwtf prplwtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly doubt this will parse correctly. The -user-confirmed-removal flag will also be parsed as an extension removal task and will always need to be the second argument.

blueprint -r example -user-confirmed-removal
Removes example, attempts removal on -user-confirmed-removal which does not exist
Does not ask for confirmation

blueprint -r example example2 -user-confirmed-removal
Removes example, removes example2, attempts removal on -user-confirmed-removal which does not exist
Asks for confirmation

blueprint -r example -user-confirmed-removal example2
Removes example, attempts removal on -user-confirmed-removal which does not exist, removes example2
Does not ask for confirmation

We currently do not have a standard way of parsing arguments to -remove, -install or any command for that matter.

@laraproto
Copy link

I highly doubt this will parse correctly. The -user-confirmed-removal flag will also be parsed as an extension removal task and will always need to be the second argument.

blueprint -r example -user-confirmed-removal Removes example, attempts removal on -user-confirmed-removal which does not exist Does not ask for confirmation

blueprint -r example example2 -user-confirmed-removal Removes example, removes example2, attempts removal on -user-confirmed-removal which does not exist Asks for confirmation

blueprint -r example -user-confirmed-removal example2 Removes example, attempts removal on -user-confirmed-removal which does not exist, removes example2 Does not ask for confirmation

We currently do not have a standard way of parsing arguments to -remove, -install or any command for that matter.

They never tested what they wrote in general because they didn't know how to build the panel

@prplwtf
Copy link
Member

prplwtf commented Mar 19, 2025

@laraproto 🤷

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants