-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: AntiBot Color option + ESP & Tracers team color #5707
base: nextgen
Are you sure you want to change the base?
Conversation
I will delay this pull request to the next milestone and review it later. Sorry. |
That's totally fine. I'm not in a rush. :) |
GenericRainbowColorMode(it) | ||
) | ||
} | ||
private val friendColor by color("Friends", Color4b.Companion.GREEN) | ||
private val friendColor by color("Friends", Color4b.GREEN) | ||
private val teamColor by color("Teammates", Color4b.CYAN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Teammates
color option is a bit confusing because we already set the color via ModuleTeams. For example, if there is a team CYAN, and we now set our teammates to CYAN, we basically cannot tell who is CYAN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. The concept might seem useless because ModuleTeams already does all the work by 'painting' players. The only thing that's required from the player is to remember which team they belong to. :)
However, I'd like to push it even more. I'm too lazy to remember which team I'm in after like 10 consecutive games, hopefully, it's not only me. :) Plus, ModuleTeams isn't guaranteed to detect a player's color. It might determine if a player is a teammate or not without knowing anything about colors. (see the Prefix option)
Since it all happens in ModuleTeams, I can introduce an option to change how colors are assigned to players. The option will have 2 modes: one that 'paints' all players like it's doing now, and the other that 'paints' only the player's teammates to a specific color defined by a color option.
Will this approach work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1zun4 [another notification, just in case the previous one was acknowledged but missed a response :)]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I forgot to respond. Yes making it configurable is fine as long it's straight forward enough.
Changes:
Color
option forAntiBot
(Custom
).ESP
andTracers
modules with a separate color for teammates..friends remove
command.