Turn queryString into a dict in evhc_grafana_jobs #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to easilly add a parameter to extend the clauses
of the graphana query. I have checked the old query expand to
the current one by using:
json.dumps(json.loads(queryString.split('\n')[0])) + '\n' +
json.dumps(json.loads(queryString.split('\n')[1]%afterTImS))
mmascher
force-pushed
the
improve_evalhc
branch
from
420b4b7 to
5c2f2e7
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to easilly add a parameter to extend the clauses
of the graphana query. I have checked the old query expand to
the current one by using:
json.dumps(json.loads(queryString.split('\n')[0])) + '\n' +
json.dumps(json.loads(queryString.split('\n')[1]%afterTImS))