Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added de_DE support, deactivated original led mapping #12

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eisenfunk
Copy link

Hi there,

the RoccatVulcanAimo module has wrong LED mappings on my german keyboard. I think of two reasons for this:

a) vulcan aimo 121 has a different mapping
b) de_DE layout is different to the original one in the code

I can't test anything else than de_DE on my vulcan 121 due to missing hardware (sorry, just one keyboard in my set :) )
But all signs point to possibility b), because the german keymap has also a slightly different Key style in the hardware layout. Producing a series of keyboards with different country codes would make sense.

I've commented the original mapping and added my de_DE mapping for Vulcan Aimo 121. So beware when you accept this pull without reediting.

br and a happy new 2022,

Michael

@CalcProgrammer1
Copy link
Owner

I've been thinking about ways to support alternate layouts on keyboards over on a GitLab MR that adds similar mapping to Razer boards. I think I would like to add a layout field to the RGBController, expose the en_US/UK keys from the RGBController, and automatically remap them based on en_US/UK to X lookup tables. Since layouts should be standard across all brands of keyboard it keeps this work out of each individual keyboard controller.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants