Adding EqualsValue filter

[adamcataldo]

No description provided.

[cwensel]

is not ExpressionFilter a reasonable alternative?

On Aug 1, 2013, at 11:15 AM, adamcataldo notifications@github.com wrote:

You can merge this Pull Request by running

git pull https://github.com/adamcataldo/cascading equalsValue
Or view, comment on, or merge it at:

#15

Commit Summary

Adding EqualsValue filter
File Changes

A src/core/cascading/operation/filter/EqualsValue.java (47)
A src/test/cascading/operation/filter/EqualsValueTest.java (38)
Patch Links:

https://github.com/Cascading/cascading/pull/15.patch
https://github.com/Cascading/cascading/pull/15.diff

Chris K Wensel
chris@concurrentinc.com
http://concurrentinc.com

[adamcataldo]

You can, but we generally avoid ExpressionFilter at my company (Wealthfront), because we put a premium on having the compiler catch as many errors as possible. The expression is just a string, so the compiler isn't able to infer much. As a result, we tend to create more narrowly-focused filters, which is a bit more up-front work, but lends itself more easily to testing, which we also put a premium on.

I've found myself using this particular filter often enough, that it seemed worth adding to the framework. In my mind, it's on par with FilterNull/FilterNotNull.