Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

#192 Made some typings optional #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#192 Made some typings optional #193

wants to merge 1 commit into from

Conversation

Brqqq
Copy link

@Brqqq Brqqq commented May 14, 2021

@guidoprinc
Copy link

channelImportance type should be `number since it's value is a double

guidoprinc
guidoprinc reviewed Jun 3, 2021
View reviewed changes
index.d.ts
channelEnableLights: boolean;
channelEnableVibration: boolean;
channelName?: string;
channelImportance?: boolean;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
channelImportance?: boolean;
channelImportance?: number;

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@guidoprinc guidoprinc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brqqq @guidoprinc