Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix maxItemText message for maxItemCount === 1 #1135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fareesh
Copy link

@fareesh fareesh commented Nov 24, 2023

Description

Minor text change to the maxItemText message for maxItemCount === 1

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Xon
Copy link
Collaborator

Xon commented Aug 22, 2024

The new singleModeForMultiSelect option basically makes this non-required for select-multiple but I guess it could apply for the text backing element.

However, please rebase this as quite a bit has changed

@Xon Xon added the changes required Pull request requires changes before it can be merged label Aug 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
changes required Pull request requires changes before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants