Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Day 1, 2, 28 and 31 added (java) #378

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

thefluffyoshi
Copy link

@thefluffyoshi thefluffyoshi commented Oct 31, 2020

Please make sure you have done the following:

  • Created a folder with the name of language you code inside directory for the day you are making the contribution to
  • Added the source code file inside /Day<n>/<Language>/
  • Tested your code
  • Added credits (author and date) at the top of the code
  • Updated README.md for /Day <n>/
  • Added yourself as a contributor using all-contributors-cli

Copy link

@aaditkamat aaditkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the files under the .idea/ directory. Ideally, this folder should be ignored by git through a .gitignore file. I've created a PR for the same.

@aaditkamat
Copy link

Also make sure you add only the solutions for the day you have mentioned in the title of the PR.

@thefluffyoshi thefluffyoshi changed the title Day 2 added (java) Day 1, 2, 28 and 31 added (java) Nov 1, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants