Update the command to package the local source into a Docker image. #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
reviewed
Oct 20, 2024
|
@as6325400 can you squash and improve the commit message by explaining why this was needed? I'll merge afterwards. |
is this okay Thank? |
|
The message is missing why we need this. If you can add that, we will merge. |
Co-authored-by: MCJ Vasseur <14887731+vmcj@users.noreply.github.com> Fix tar command to work with absolute source path by computing dirname and basename, as executing from the wrong directory can cause the build to fail
I’ve added the missing message. I also noticed there was an extra quotation mark (") in my previous command, and I’ve fixed that as well. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packaging my local source into a package, I encountered an error because I didn't execute the command in the parent directory of DOMjudge. It took me some time to realize the issue when I initially filled in the absolute path for
<domjudge source directory>.I believe it should be mentioned in the README to execute the command in the parent directory of DOMjudge, or the changes made in this PR could help avoid this issue.