feat(flink): implement suggestion support for table properties in CREATE TABLE #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ATE TABLE # Conflicts: # test/parser/flink/suggestion/tokenSuggestion.test.ts
ekazakas
changed the title
|
@JackWang032 @Cythia828 @liuxy0551 I have closed the #392 since it was based from main branch and caused quite a bit of conflicts. It was much simpler to branch off the |
|
ci failed @ekazakas |
liuxy0551
reviewed
May 8, 2025
liuxy0551
approved these changes
May 12, 2025
mumiao
approved these changes
May 16, 2025
|
+1 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented SQL suggestion support for Flink table properties to work with ANTLR C3.
Related conversation: #391
Previous PR: #392 closed due to a mess with resolving conflicts