Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: adjust and extend activityService method of remove data #436

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

ProfBramble
Copy link
Contributor

Description

Adjust and extend activityService to delete method

Changes

  • adjust activityService remove and removeContextMenu methods to use immutable data
  • compatible with the original API and support array deletion

@ProfBramble ProfBramble added the refactoring Refactor label Sep 16, 2021
@ProfBramble ProfBramble added this to the 0.9.0-beta.1 milestone Sep 16, 2021
@ProfBramble ProfBramble self-assigned this Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #436 (b552cbe) into main (44c2a7b) will increase coverage by 0.01%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   81.09%   81.10%   +0.01%     
==========================================
  Files         177      177              
  Lines        4882     4890       +8     
  Branches     1052     1053       +1     
==========================================
+ Hits         3959     3966       +7     
- Misses        914      915       +1     
  Partials        9        9              
Impacted Files Coverage Δ
src/workbench/activityBar/activityBar.tsx 97.43% <ø> (ø)
src/services/workbench/activityBarService.ts 98.59% <95.23%> (-1.41%) ⬇️
src/model/workbench/activityBar.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c2a7b...b552cbe. Read the comment docs.

@mortalYoung
Copy link
Collaborator

批量删除的测试用例补一哈

@ProfBramble
Copy link
Contributor Author

done

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ProfBramble ProfBramble merged commit 3dc3f49 into main Sep 16, 2021
@ProfBramble ProfBramble deleted the feat/sidebar branch September 16, 2021 08:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
refactoring Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants