Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP: feat: sort the order of language packs in English and terminology not translated in Workbench #593

Closed
wants to merge 36 commits into from

Conversation

SQLGate
Copy link
Collaborator

@SQLGate SQLGate commented Jan 4, 2022

All variables in the language pack are sorted alphabetically.
However, in the process of multilingualization, we tried to make the variable name as similar to the existing name as possible.

SQLGate and others added 30 commits December 21, 2021 15:19
Co-authored-by: Ziv <wewoor@gmail.com>
@SQLGate SQLGate changed the title feat: sort the order of language packs in English and terminology not translated in Workbench WIP: feat: sort the order of language packs in English and terminology not translated in Workbench Jan 4, 2022
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #593 (db745a9) into main (7229fc5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files         190      190           
  Lines        5578     5578           
  Branches     1243     1243           
=======================================
  Hits         4869     4869           
  Misses        699      699           
  Partials       10       10           
Impacted Files Coverage Δ
src/services/builtinService/const.ts 100.00% <ø> (ø)
.../workbench/notification/notificationPane/index.tsx 100.00% <ø> (ø)
...tification/notificationPane/localeNotification.tsx 100.00% <ø> (ø)
src/workbench/sidebar/explore/folderTree.tsx 97.59% <ø> (ø)
src/workbench/sidebar/search/searchPanel.tsx 92.68% <ø> (ø)
stories/extensions/problems/index.tsx 75.00% <ø> (ø)
stories/extensions/test/index.tsx 24.19% <ø> (ø)
stories/extensions/test/testPane.tsx 47.05% <ø> (ø)
src/components/search/index.tsx 94.73% <100.00%> (ø)
src/workbench/editor/statusBarView/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7229fc5...db745a9. Read the comment docs.

@wewoor wewoor requested review from mortalYoung and wewoor January 5, 2022 02:29
@mortalYoung
Copy link
Collaborator

Sorry, I get confused about what this PR want to do. Because I can view the changes from other PRs. Would you mind to checkout a new branch from main, cherry-pick the commits you really want so that to keep the commit logs clear. Thanks a lot~

@SQLGate SQLGate closed this Jan 9, 2022
@SQLGate
Copy link
Collaborator Author

SQLGate commented Jan 9, 2022

As you said, we will do PR again at a clean brunch.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants