Add CreateCustomFramework and UpdateCustomFramework endpoints #2356
+706
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![api-clients-generation-pipeline[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
api-clients-generation-pipeline
bot
requested a review
from a team
as a code owner
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| "name": "name", | ||
| } | ||
|
|
||
| def __init__(self_, controls: List[FrameworkControl], name: str, **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, controls: List[FrameworkControl], name: str, **kwargs): | |
| def __init__(self, controls: List[FrameworkControl], name: str, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
| "rule_ids": "rule_ids", | ||
| } | ||
|
|
||
| def __init__(self_, name: str, rule_ids: List[str], **kwargs): |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| def __init__(self_, name: str, rule_ids: List[str], **kwargs): | |
| def __init__(self, name: str, rule_ids: List[str], **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3481
branch
from
2a28745 to
0e90516
Compare
api-clients-generation-pipeline
bot
changed the title
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3481
branch
from
0e90516 to
aa5556c
Compare
| } | ||
|
|
||
| def __init__( | ||
| self_, |
There was a problem hiding this comment.
🔴 Code Quality Violation
Suggested change
| self_, | |
| self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self by convention.
Learn More
amaskara-dd
approved these changes
Jan 15, 2025
api-clients-generation-pipeline
bot
changed the title
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3481
branch
4 times, most recently
from
e51f0dd to
0e80887
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3481
branch
from
0e80887 to
4049c4a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#3481
Test branch datadog-api-spec/test/vbarth/add-create-custom-framework