Skip to content

Normalize phrasing across rate/trace_rate in APM Retention Filters #2145

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-11 15:05:33.216821",
"spec_repo_commit": "d209cd40"
"regenerated": "2025-04-14 08:41:56.357428",
"spec_repo_commit": "e73254d7"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-11 15:05:33.232842",
"spec_repo_commit": "d209cd40"
"regenerated": "2025-04-14 08:41:56.373102",
"spec_repo_commit": "e73254d7"
}
}
}
16 changes: 8 additions & 8 deletions .generator/schemas/v2/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25398,9 +25398,9 @@ components:
type: string
rate:
description: 'Sample rate to apply to spans going through this retention
filter,
filter.

a value of 1.0 keeps all spans matching the query.'
A value of 1.0 keeps all spans matching the query.'
example: 1.0
format: double
type: number
Expand Down Expand Up @@ -25465,9 +25465,9 @@ components:
type: string
rate:
description: 'Sample rate to apply to spans going through this retention
filter,
filter.

a value of 1.0 keeps all spans matching the query.'
A value of 1.0 keeps all spans matching the query.'
example: 1.0
format: double
type: number
Expand Down Expand Up @@ -25498,9 +25498,9 @@ components:
type: string
rate:
description: 'Sample rate to apply to spans going through this retention
filter,
filter.

a value of 1.0 keeps all spans matching the query.'
A value of 1.0 keeps all spans matching the query.'
example: 1.0
format: double
type: number
Expand Down Expand Up @@ -25577,9 +25577,9 @@ components:
type: string
rate:
description: 'Sample rate to apply to spans going through this retention
filter,
filter.

a value of 1.0 keeps all spans matching the query.'
A value of 1.0 keeps all spans matching the query.'
example: 1.0
format: double
type: number
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ export class RetentionFilterAllAttributes {
*/
"name"?: string;
/**
* Sample rate to apply to spans going through this retention filter,
* a value of 1.0 keeps all spans matching the query.
* Sample rate to apply to spans going through this retention filter.
* A value of 1.0 keeps all spans matching the query.
*/
"rate"?: number;
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ export class RetentionFilterAttributes {
*/
"name"?: string;
/**
* Sample rate to apply to spans going through this retention filter,
* a value of 1.0 keeps all spans matching the query.
* Sample rate to apply to spans going through this retention filter.
* A value of 1.0 keeps all spans matching the query.
*/
"rate"?: number;
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ export class RetentionFilterCreateAttributes {
*/
"name": string;
/**
* Sample rate to apply to spans going through this retention filter,
* a value of 1.0 keeps all spans matching the query.
* Sample rate to apply to spans going through this retention filter.
* A value of 1.0 keeps all spans matching the query.
*/
"rate": number;
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ export class RetentionFilterUpdateAttributes {
*/
"name": string;
/**
* Sample rate to apply to spans going through this retention filter,
* a value of 1.0 keeps all spans matching the query.
* Sample rate to apply to spans going through this retention filter.
* A value of 1.0 keeps all spans matching the query.
*/
"rate": number;
/**
Expand Down