[Op] Implement GPU version of KvResourceSparseApplyAdam. #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liutongxuan
reviewed
Nov 9, 2022
|
|
||
| const Device& device = ctx->eigen_device<Device>(); | ||
| OP_REQUIRES_OK(ctx, | ||
| functor::KvSparseApplyAdamAsync<Device, T, Tindex, Tstep>()( |
There was a problem hiding this comment.
是的，我注意到AdamAsync的functor中逻辑代码与Adam相同，只是AdamAsync多了apply_sparse_rmsprop参数，于是考虑复用functor逻辑代码，不同在于将Adam 中调用的functor 中apply_sparse_rmsprop 置为了false
There was a problem hiding this comment.
嗯，我建议新写一个functor::KvSparseApplyAdam，而不是复用这个，避免别人改AdamAsync的functor而影响到这里的逻辑正确性
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.