Autoexposure example restoration #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Examples-and-Tests into autoexposure_ex
…Examples-and-Tests into autoexposure_ex
…Examples-and-Tests into autoexposure_ex
…Examples-and-Tests into autoexposure_ex
…Examples-and-Tests into autoexposure_ex
Comment on lines
12
to
17
| float meteringWindowScaleX, meteringWindowScaleY; | ||
| float meteringWindowOffsetX, meteringWindowOffsetY; | ||
| float lumaMin, lumaMax; | ||
| uint32_t sampleCountX, sampleCountY; | ||
| uint32_t viewportSizeX, viewportSizeY; | ||
| uint64_t lumaMeterBDA; |
There was a problem hiding this comment.
you should pack these up intro structs in nbl::hlsl::luma_meter and friends
P.S. I see you already have, why not use things like nbl::hlsl::luma_meter::LumaMeteringWindow directly here?
…Examples-and-Tests into autoexposure_ex
|
Whats the status on this? |
|
Before merge this needs to become example 27 or some other free number |
…Examples-and-Tests into autoexposure_ex
…Examples-and-Tests into autoexposure_ex
…e sure its asset conversion cache is written to
Comment on lines
+583
to
+649
| // transition m_tonemappedImgView to GENERAL | ||
| { | ||
| auto transitionSemaphore = m_device->createSemaphore(0); | ||
| auto queue = getGraphicsQueue(); | ||
| auto cmdbuf = m_cmdBufs[0].get(); | ||
| cmdbuf->reset(IGPUCommandBuffer::RESET_FLAGS::NONE); | ||
|
|
||
| m_api->startCapture(); | ||
|
|
||
| cmdbuf->begin(IGPUCommandBuffer::USAGE::ONE_TIME_SUBMIT_BIT); | ||
|
|
||
| // TRANSITION m_outImgView to GENERAL (because of descriptorSets0 -> ComputeShader Writes into the image) | ||
| { | ||
| const IGPUCommandBuffer::SImageMemoryBarrier<IGPUCommandBuffer::SOwnershipTransferBarrier> imgBarriers[] = { | ||
| { | ||
| .barrier = { | ||
| .dep = { | ||
| .srcStageMask = PIPELINE_STAGE_FLAGS::NONE, | ||
| .dstStageMask = PIPELINE_STAGE_FLAGS::ALL_COMMANDS_BITS, | ||
| } | ||
| }, | ||
| .image = m_tonemappedImgView->getCreationParameters().image.get(), | ||
| .subresourceRange = { | ||
| .aspectMask = IImage::EAF_COLOR_BIT, | ||
| .baseMipLevel = 0u, | ||
| .levelCount = 1u, | ||
| .baseArrayLayer = 0u, | ||
| .layerCount = 1u | ||
| }, | ||
| .oldLayout = IImage::LAYOUT::UNDEFINED, | ||
| .newLayout = IImage::LAYOUT::GENERAL | ||
| } | ||
| }; | ||
| cmdbuf->pipelineBarrier(E_DEPENDENCY_FLAGS::EDF_NONE, { .imgBarriers = imgBarriers }); | ||
| } | ||
| cmdbuf->end(); | ||
|
|
||
| const IQueue::SSubmitInfo::SSemaphoreInfo rendered[] = | ||
| { | ||
| { | ||
| .semaphore = transitionSemaphore.get(), | ||
| .value = 1, | ||
| .stageMask = PIPELINE_STAGE_FLAGS::ALL_COMMANDS_BITS | ||
| } | ||
| }; | ||
| const IQueue::SSubmitInfo::SCommandBufferInfo commandBuffers[] = | ||
| { | ||
| {.cmdbuf = cmdbuf } | ||
| }; | ||
| const IQueue::SSubmitInfo infos[] = | ||
| { | ||
| { | ||
| .waitSemaphores = {}, | ||
| .commandBuffers = commandBuffers, | ||
| .signalSemaphores = rendered | ||
| } | ||
| }; | ||
| queue->submit(infos); | ||
| const ISemaphore::SWaitInfo waits[] = { | ||
| { | ||
| .semaphore = transitionSemaphore.get(), | ||
| .value = 1 | ||
| } | ||
| }; | ||
| m_device->blockForSemaphores(waits); | ||
| m_api->endCapture(); | ||
| } |
There was a problem hiding this comment.
btw you could also create the m_tonemappedImgView from an empt ICPUImage using asset converter and override its layout in the callback, that would give you an already transitioned empty image
…ould the SPIR-V legalization pass just decide to kill implicit lod texture sampling operations and just warn? GLSL makes them into explicit lod with implied lod 0.
Comment on lines
+54
to
+57
| uint32_t3 glsl::gl_WorkGroupSize() | ||
| { | ||
| return uint32_t3(DeviceSubgroupSize, DeviceSubgroupSize, 1); | ||
| } |
There was a problem hiding this comment.
wrong, because some devices will do 128 or 64 subgroups and you can't have a 128x128 or 64x64 workgroup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.