Skip to content

Use Path.Combine instead of string concatenation #1112

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Use Path.Combine instead of string concatenation #1112

wants to merge 3 commits into from

Conversation

vincent1405
Copy link

Use:

Path.Combine(path, meta.WSDLFolder, wsdlfile)

instead of

path + Path.AltDirectorySeparatorChar + meta.WSDLFolder + Path.AltDirectorySeparatorChar + wsdlfile

@vincent1405
Update SoapEndpointMiddleware.cs
1a23e07 
Use Path.Combine to create a file path to WsdlFile.
@vincent1405
Update SoapEndpointMiddleware.cs
1fd2227 
Fix missing )
@andersjonsson
Copy link
Collaborator

Thanks for the PR. Unfortunately, it doesn't build. Can you fix the errors please?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@andersjonsson andersjonsson andersjonsson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent1405 @andersjonsson