Add vim-nerdfont, vim-glyph-palette, and vim-nerdtree-syntax-highlight compatibility #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmrwoods
force-pushed
the
compat_hacks
branch
2 times, most recently
from
62ac3fb to
30df6f4
Compare
Automatically use colors from vim-nerdtree-syntax-highlight if installed See https://github.com/tiagofumo/vim-nerdtree-syntax-highlight This adds a compatibility script triggered via VimEnter autocmd, which updates the devicons color table before highlight groups are created. To allow the color table to be modified before the highlight groups are created it has been moved from the devicons script to the colors script.
Automatically use glyph-palette for devicon colors if installed See https://github.com/lambdalisue/vim-glyph-palette
Automatically use vim-nerdfont to obtain devicon glyphs if installed See https://github.com/lambdalisue/vim-nerdfont
Keep all plugin compatibility code in one place, easier to understand
|
@Donaldttt I'm reluctant to merge this without a review, if you could have a glance when you get some time that would be great, thanks :-) It seems sensible to me, obviously, I've tested it pretty extensively, including Vim 9.0 ;-), and it's based on the compatibility scripts known to work for vim-friendly and auto-pairs. |
|
@Donaldttt I'm going to go ahead and merge this as I have some other changes dependent on it and I don't think there is anything contentious here. Suggested changes/improvements can be made later. |
|
Sorry about this late reply. I didn't test it. But I read the code and use it brieftly and I think It's really nice. This feature makes the style consistent for many users. |
|
Thanks, glad you like it :-) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new compat script loaded on VimEnter where compatibilities with other plugins can be defined, moves the existing vim-devicons compatibility code to that compat script, and adds similar code for vim-nerdfont, vim-glyph-palette, and vim-nerdtree-syntax-highlight.
vim-devicons remains the first priority for the devicons glyph function, vim-glyph-palette and vim-nerdtree-syntax-highlight will only be used automatically if the user has not already set g:fuzzyy_devicons_color_func. For an existing user of nerdtree, vim-nerdtree-syntax-highlight, and fuzzyy, they will now magically get the same colors in Fuzzyy as in NERDTree (for all devicons known to Fuzzyy)
before
after (with vim-nerdtree-syntax-highlight)
after (with vim-glyph-palette)
after (with vim-nerdfont, and without vim-devivons)
